-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admins to carbonplan hub #567
Conversation
Let's do it like https://github.com/2i2c-org/pilot-hubs/blob/151faa89e92d7ca596a31bbe9e58e16de758a2f7/config/hubs/2i2c.cluster.yaml#L50 instead? That'll mean only the listed users can log in (right now anyone with GitHub can login lol), and they can add more users in the admin panel when they need to log in. |
Also #558 is needed to deploy to the new carbonplan hub |
ok I think this is what you mean? Do we also need to do this in the openscapes hub? https://github.com/2i2c-org/pilot-hubs/blob/151faa89e92d7ca596a31bbe9e58e16de758a2f7/config/hubs/openscapes.cluster.yaml We should document this in the pilot hubs docs (maybe we should rename that to "Hub Engineer Handbook/guide/etc"?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! I think we should do this for openscapes (and all our hubs really), since otherwise anyone with a github login can get in.
The * and & are YAML anchors that need to be unique within the document, so they were <hubname>_users
in 2i2c.clusters.yaml. Not the case here though.
There's docs on adding new users in https://pilot.2i2c.org/en/latest/admin/howto/manage-users.html, but we should have equivalent in the '2i2c engineer handbook'
Only one set of users in this file
I tried to mimic how this is done on the OpenScapes hub
closes #566